Refactor cib library structure
#660
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: - `cib` offers `builder_meta` as a convenient way to provide a service. But sometimes other libs depend on cib only to use that, when instead they could be providing a service easily by modelling a concept. Solution: - Change `builder_meta` to a concept; libraries that don't need cib otherwise need not use it.
elbeno
force-pushed
the
decouple-service
branch
2 times, most recently
from
ca2f48c to
fcd948b
Compare
Problem: - The dependency DAG between `cib` sub libraries is not well-defined. Solution: - Define it. Each library "level" depends on the level below. Level 0 libraries: - `async` - `conc` - `fmt` - `stdx` Level 1 libraries: - `cib_lookup` depends on `stdx` - `cib_nexus` depends on `stdx` - `cib_sc` depends on `fmt`, `stdx` Level 2 libraries: - `cib_log` depends on `cib_sc` - `cib_match` depends on `cib_sc` - `cib_interrupt` depends on `conc`, `cib_sc` Level 3 libraries: - `cib_flow` depends on `cib_log`, `cib_nexus`, `cib_sc` - `cib_log_fmt` depends on `cib_log` - `cib_msg` depends on `async`, `cib_log`, `cib_lookup`, `cib_match`, `cib_sc` Level 4 libraries: - `cib_log_mipi` depends on `conc`, `cib_log`, `cib_msg` - `cib_seq` depends on `cib_flow`, `cib_log`, `cib_nexus`, `cib_sc` Level 5 libraries: - `cib` depends on `cib_*` Note: - No code has moved, so includes remain valid. `cib` remains as an omnibus library. But this paves the way (if we want) to move code around and separate the libraries more.
elbeno
force-pushed
the
decouple-service
branch
2 times, most recently
from
e905cb0 to
28055ae
Compare
elbeno
force-pushed
the
decouple-service
branch
from
28055ae to
5b88897
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
cibsub libraries is not well-defined.Solution:
Level 0 libraries:
asyncconcfmtstdxLevel 1 libraries:
cib_lookupdepends onstdxcib_nexusdepends onstdxcib_scdepends onfmt,stdxLevel 2 libraries:
cib_logdepends oncib_sccib_matchdepends oncib_sccib_interruptdepends onconc,cib_scLevel 3 libraries:
cib_flowdepends oncib_log,cib_nexus,cib_sccib_log_fmtdepends oncib_logcib_msgdepends onasync,cib_log,cib_lookup,cib_match,cib_scLevel 4 libraries:
cib_log_mipidepends onconc,cib_log,cib_msgcib_seqdepends oncib_flow,cib_log,cib_nexus,cib_scLevel 5 libraries:
cibdepends oncib_*Note:
cibremains as an omnibus library. But this paves theway (if we want) to move code around and separate the libraries more.